Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Dialog + fxDuration set to zero -> invisible Dialog

#399

I just tried to show a Dialog without any delay. I did this by setting its fxDuration to zero. To my surprise no dialog was shown.

I noticed there's a slight issue in the Dialog code causing this. If you take a look at the else section of "if (this.options.fxDuration) {" at "show" method you'll see Dialog opacity is set to zero by default. I guess one would be a more reasonable default. :)

As a related note I didn't find any official documentation for "fxDuration" at the Dialog page. It would also be good to document possible durations (short, normal, long + numeric) of Fx.Morph at its page.

Reported by Juho Vepsäläinen · November 6th, 2010 @ 09:15 AM

State: resolved
Milestone: none
Assigned to: nobody

Activity

  1. MadRabbit
    MadRabbit
    • Tag changed from dialog to bug, dialog, ui

    Hi Juho,

    yah the fxDuration is a recent hack, I didn't have time to document it yet. Try to use 1 instead of 0 as a temporary solution, I'll fix this later

    November 7th, 2010 @ 10:57 AM

  2. Juho Vepsäläinen
    Juho Vepsäläinen

    Did that. :P

    Good to hear it's on TODO. :)

    November 7th, 2010 @ 11:03 AM

  3. MadRabbit
    MadRabbit
    • State changed from new to resolved

    Hey man, I've finally got to the ticket. Just fixed the issue, apperantly there was a typo in the code.

    Check out the fresh builds at the attachment.

    And merry xmas by the way ;)

    December 25th, 2010 @ 07:43 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.