Illegal use of reserved words
-
MadRabbit
Did you run into any sort of problems with that?
-
Paul Bronshteyn aka pbcomm
Yes. While trying to minify using YUI Compressor the compiler return 66 errors. But in general it is not the best practice to used any language reserved words.
-
MadRabbit
okay I see the point. Will fix it.
Btw how is the result with YUI against FrontCompiler?
-
Paul Bronshteyn aka pbcomm
It's 47k compressed, but gives much better performance gzipped.
-
MadRabbit
have you tried the custom build without the self-build feature?
here
http://rightjs.org/buildsuncheck the 'self-build' checkbox. it should give you pretty much the same thing YUI builds.
-
Paul Bronshteyn aka pbcomm
Yes, very close. 47.6k vs 46.3 with YUI.
I would also suggest going through some of the for loops which still is some cases use i < var.length, and would also suggest using === everywhere for better performance.
Might also want to store navigator.userAgent is browser as ua: navigator.userAgent and using this.ua will save a few bites.Going through the code to see if I can chop of a bit more of it.
There is also a mistype in cookie documentation "new Cooke" instead of "new Cookie". Get, remove and set are also there twice.
-
MadRabbit
I've just had 47.5 with YUI 2.4.2 and RightJS 1.4.1
There are two methods at Cookie a class level and instance level
I've fixed the keywords and docs, and pushed the things to git. Will update the build in a minute.
-
MadRabbit
- State changed from new to resolved
Okay, here it is. http://rightjs.org/download
Thanks for help!
-
Paul Bronshteyn aka pbcomm
No probs ;)
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.