Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Display calendar time input in the same fashion as is specified by the format

#82

For a given date format, the input selection boxes should be as similar as possible to the format option. For example, specifying a format that includes the meridian indicator (%P or %p) should adjust the input selection boxes to have an AM/PM dropdown; indicating a 12 hour time of day period (with %I or %l) should adjust the selection box to only allow for 0 - 11, etc.

Reported by Damian Carrillo · September 12th, 2009 @ 09:54 AM

State: resolved
Milestone: none
Assigned to: nobody

Activity

  1. Damian Carrillo
    Damian Carrillo

    I went ahead and fixed this issue. You can see an example of the fix at the end of test in .../test/calendar/index.html. Here are the items I addressed:

    • Made the calendar builder respect the supplied (or preconfigured format) for the time section. A meridian dropdown is now included, as well as respecting the 12/24 hour format for the hour.
    • The hour dropdown shows a 12 instead of a 0 or 00 when the format specifies 12 hour time. When the timePeriod exceeds 59, this is overridden.
    • Added more space and a horizontal separator between the calendar and the time.
    • Made the calendar always select an hour, minute, and meridian if applicable so that when the events are fired, the selected menu option applies to the output time.

    I am attaching the patch, but here is some information about the patch:

    Result from git status

    #    modified:   src/calendar/calendar.css
    #   modified:   src/calendar/calendar.js
    #   modified:   src/calendar/calendar/builder.js
    #   modified:   src/calendar/calendar/formats.js
    #   modified:   test/calendar/index.html
    

    Last Few Results from git log

    commit 7ccbff8090a419424f44e93ef3bb2dd020513e5b
    Author: Nikolay V. Nemshilov aka St <nemshilov@gmail.com>
    Date:   Sat Sep 5 16:26:32 2009 +0400
    
        Lightbox scrolling block fix
    
    commit ce0d1ba5dd19cd3df2f6d4127c713fee80378cbd
    Author: Nikolay V. Nemshilov aka St <nemshilov@gmail.com>
    Date:   Fri Sep 4 15:32:17 2009 +0400
    
        Lightbox mouse wheel support
    
    commit 32f7fd8fdcbc060e3b787fc19a26242adab48e42
    Author: Nikolay V. Nemshilov aka St <nemshilov@gmail.com>
    Date:   Fri Sep 4 15:06:39 2009 +0400
    
        Calendar with the tab button hidding
    

    September 14th, 2009 @ 07:38 AM

  2. Damian Carrillo
    Damian Carrillo

    In the previous patch, I did not bind a couple of events. This new patch resolves the issue, and contains all of the changes from the previous patch as well.

    September 14th, 2009 @ 09:26 AM

  3. MadRabbit
    MadRabbit
    • State changed from new to resolved

    Hey Damian,

    I've applied your patch. Will publish the things with some other updates a bit later,

    Cheers,
    Nik

    September 17th, 2009 @ 07:11 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.